fix: failing/empty graph and timeline tabs upon relaunch data updates #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>
Signed-off-by: eugenejahn <[email protected]>
* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: eugenejahn <[email protected]>
#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>
* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>
* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>
* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
* chore: support for StructuredDataSet Input/Output type Signed-off-by: Carina Ursu <[email protected]> * chore: add tests Signed-off-by: Carina Ursu <[email protected]> * chore: add package Signed-off-by: Carina Ursu <[email protected]> * chore: resolving local package issue Signed-off-by: Carina Ursu <[email protected]> * chore: yarn lock Signed-off-by: Carina Ursu <[email protected]> * chore: stories Signed-off-by: Carina Ursu <[email protected]> * chore: fix associative arrays in copy functionality Signed-off-by: Carina Ursu <[email protected]> * chore: fix scalar stories Signed-off-by: Carina Ursu <[email protected]> * chore: oops Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: revert old viewer to original Signed-off-by: Carina Ursu <[email protected]> * chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove non-null assertion Signed-off-by: Carina Ursu <[email protected]> * chore: fix types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: fix tests Signed-off-by: Carina Ursu <[email protected]> * chore: fix test types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>
…scode setup properly (#458) * chore: separate AppInfo * chore: vscode properly understands @flyteconsole * chore: add basics/locale entry * test: add storybooks and tests * test: fix istanbul test-coverage issue by binding babel versions Signed-off-by: Nastya Rusina <[email protected]>
* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>
* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>
* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>
* chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove console Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>
Signed-off-by: Nastya <[email protected]>
Signed-off-by: Nastya <[email protected]>
made the entities component become more generic that can support Workflow, Task, and others added the inputs and outputs to task details page added the versions table in task details page added the version details page added task details link in node side panel Signed-off-by: eugenejahn <[email protected]> Co-authored-by: Eugene Jahn <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>
* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>
#578) fix: correctly coerce defaultValue when rendering LaunchPlan details Signed-off-by: Rahul Mehta <[email protected]> Signed-off-by: Rahul Mehta <[email protected]>
fix: inputHelpers InputProps Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>
* fix: fix test of launchform Signed-off-by: James <[email protected]> * fix: inputHelpers tests regression Signed-off-by: Olga Nad <[email protected]> * fix: update tests description Signed-off-by: Olga Nad <[email protected]> * fix: spelling typo Signed-off-by: Olga Nad <[email protected]> Signed-off-by: James <[email protected]> Signed-off-by: Olga Nad <[email protected]> Co-authored-by: Olga Nad <[email protected]>
Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>
Minor change Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>
…#582) Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
* fix: add BASE_URL to dev startup, open deeply nested urls Signed-off-by: Carina Ursu <[email protected]> * fix: remove debug code Signed-off-by: Carina Ursu <[email protected]> * chore: empty BASE_URL handling Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>
* fix: add default disabled state for only mine filter Signed-off-by: Olga Nad <[email protected]> * fix: tests Signed-off-by: Olga Nad <[email protected]> * fix: use api context to default filter state Signed-off-by: Olga Nad <[email protected]> * fix: revert test updates Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>
chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
olga-union
commented
Oct 27, 2022
| @@ -236,6 +236,11 @@ export const buildGraphMapping = (props): ReactFlowGraphMapping => { | |||
| const parse = (props: ParseProps) => { | |||
| const { contextNode, contextParent, rootParentNode, nodeDataProps } = props; | |||
| let context: ReactFlowGraph | null = null; | |||
| if (!contextNode) { | |||
There was a problem hiding this comment.
we should no longer reach this path with empty contextNode, but added a debugger message, just in case, for easier investigation of potential bugs in future.
olga-union
requested review from
a team,
ursucarina,
eugenejahn and
james-union
and removed request for
a team
jsonporter
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Re-renders were throwing errors/displaying empty pages, when components got empty data blips while waiting on workflow status updates, from which they couldn't recover. Updated effect in Timeline, and added a skip of graph render in case of empty
dagvariable (displaying a message that the graph is empty), as the graph state is complex and not easily adjustable from one point from the empty state, plus saving on render/computation cost in this scenario.Type
Are all requirements met?
Demo
Graph
https://user-images.githubusercontent.com/101579322/198358307-37170ee6-a2cc-494a-bf32-b9c21503de87.mov
Timeline
https://user-images.githubusercontent.com/101579322/198358362-6a90ad50-3c41-4202-96ac-3dfe20ea18ac.mov
Tracking Issue
NA
Follow-up issue
NA